fix foreign key serialization in _format_field_value #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug that occurred under the following circumstances:
manager.on_conflict(conflict_fields, ConflictAction.NOTHING).bulk_insert(...),conflict_fieldsincludes the name of aForeignKeyfield,UUIDField.When attempting to do this, the following would happen:
bulk_insertwould call_rewrite_insert_nothing(...)where_clausewould include something likefoo_id = %s_format_field_value("foo")would callprepare_value, passing it an instance of theFoomodelget_db_prep_saveis called on theForeignKeyfieldget_db_prep_saveis called onFoo's primary key (aUUIDField)UUIDField.to_pythonattempts to coerce the instance of theFoomodel into aUUID, raising an error.